[Assembly] Default label styles are annoying


#1

Currently, labels in MIPS and presumably other assembly languages are styled very weirdly. They are rendered as superscripts, the characters are not equal width with the rest of the code, and there is padding all around. This make writing assembly in Atom very annoying.

Labels are drawn as if they are not important. Granted, labels aren’t used that often in all of these nice, modern programming languages, but as they are used in assembly, labels are very important.

I’ve listed below the default label styles I see in the dev tools. I think all of these styles are unnecessary, but at the very least they should have 100% font-size, normal font-weight, and no padding so that they match the surrounding code.

For now I’ve fixed them in my personal stylesheet, but I can whip up a pull request if other people agree that this is a problem.

P.S. Does anyone know which package is responsible for those styles? It’s not the language-mips package afaik.

.label {
    display: inline;
    padding: .2em .6em .3em;
    font-size: 75%;
    font-weight: bold;
    line-height: 1;
    color: #ffffff;
    text-align: center;
    white-space: nowrap;
    vertical-align: baseline;
    border-radius: .25em;
}```

<img src="/uploads/github_atom/336/32994364fc5d28fe.png" width="580" height="500"> 

#2

I bet this is the same problem I ran across as described here: http://discuss.atom.io/t/odd-formatting-of-close-parens-brackets-braces/4794


#3

Confirmed. This is another case of Bootstrap conflicting with syntax-marked styles. In this case: https://github.com/twbs/bootstrap/blob/master/less/labels.less


#4

Wow! I didn’t realize Atom used Bootstrap. Why in the world do they do that? Are there any plans to move to a more general CSS reset? I wouldn’t mind helping out with one.

Do we have access to that part of Atom?


#5

Not as far as I can tell.


#6

Per https://github.com/atom/highlights/issues/2, this is now being tracked on the (non-public I think) main Atom repo.

(Added similar comment to the issue I originally reported, as well.)


#7

Now that the core app is public, so is the bug: https://github.com/atom/atom/issues/1800